fix(core): Unload any existing version of a community nodes package before upgrading it #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
changed the title
n8n-assistant
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
PAY-2233-fix-community-package-upgrade
|
| Run status |
|
| Run duration | 04m 47s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
477
|
| View all changes introduced in this branch ↗︎ | |
|
|
netroy
force-pushed
the
PAY-2233-fix-community-package-upgrade
branch
from
6fdb479
to
103120d
Compare
tomi
approved these changes
Nov 15, 2024
|
|
1 similar comment
|
|
netroy
force-pushed
the
PAY-2233-fix-community-package-upgrade
branch
from
103120d
to
6f5240b
Compare
netroy
force-pushed
the
PAY-2233-fix-community-package-upgrade
branch
from
6f5240b
to
4bd920d
Compare
|
had to rebase to get the e2e fix in. |
tomi
approved these changes
Nov 19, 2024
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This broke because in #10979 we added a check to prevent loading a second copy of a nodes package.
This PR updates the community package install/upgrade code to first unload the current copy of the package
Related Linear tickets, Github issues, and Community forum posts
Fixes #11723
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)